Assembly version of ServiceStack.OrmLite.nupkg seems to be incorrect

miles · December 28, 2021, 8:44am

Hi!

We are using ServiceStack.OrmLite and having a trouble.

Problem

Assembly version of ServiceStack.OrmLite.nupkg 5.10.4 seems to be incorrect.
Expected assembly version is 5.10.4.0, but actual is 5.0.0.0.
https://www.nuget.org/packages/ServiceStack.OrmLite/5.10.4

This causes us a trouble in updating our product.
We used to use ServiceStack.OrmLite.nupkg 5.1.0 in the older product, assembly version of it is correct.
When we update our product by our installer, ServiceStack.OrmLite shoud be updated from 5.1.0.0 to 5.10.4.0.
But assembly version is from 5.1.0.0 to 5.0.0.0 (this should be 5.10.4.0), so installer cannnot replace it properly.
2021-12-28_15h24_49

Cause

In this line, assembly version of ServiceStack.OrmLite is fixed to 5.0.0.0.

github.com

ServiceStack/ServiceStack.OrmLite/blob/master/src/Directory.Build.props#L5


<Project>


  <PropertyGroup>
    <Version>5.13.3</Version>
    <AssemblyVersion>5.0.0.0</AssemblyVersion>
    <Authors>ServiceStack</Authors>
    <Company>ServiceStack, Inc.</Company>
    <Copyright>&#169; 2008-2022 ServiceStack, Inc</Copyright>
  	<PackageOutputPath>$(MSBuildProjectDirectory)/../../NuGet/</PackageOutputPath>
    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
    <PackageProjectUrl>https://github.com/ServiceStack/ServiceStack.OrmLite</PackageProjectUrl>
    <PackageLicenseUrl>https://servicestack.net/terms</PackageLicenseUrl>
    <PackageIconUrl>https://servicestack.net/img/logo-64.png</PackageIconUrl>
    <PackageReleaseNotes>https://docs.servicestack.net/release-notes-history</PackageReleaseNotes>
    <RepositoryType>git</RepositoryType>

So, could you please publish ServiceStack.OrmiLite.nupkg as 5.10.4 by deleting the AssemblyVersion definition in the line?

Best regards,

mythz · December 28, 2021, 10:19am

It’s intentional for the AssemblyVersion which is used in the Assembly’s Strong Naming identity to always retain the major version i.e. 5.0.0.0, but you should be able to use the AssemblyFileVersion to detect the version of the Assembly however this didn’t seem to be properly generated in OrmLite projects which should be resolved in this commit:

This change is available from v5.13.3+ that’s now available on MyGet.

miles · January 11, 2022, 2:17am

Thank you!
That works great