AuthProviderSync LogoutAsync should return response from Logout

juhai · December 17, 2020, 11:49pm

Hello,

I think AuthProviderSync implemantation of LogoutAsync should return response from Logout, that could be for example redirect.

public Task LogoutAsync(IServiceBase service, Authenticate request, CancellationToken token = default)
{
// Logout(service, request);
// return TypeConstants.EmptyTask;
// Should return response from Logout()
var response = Logout(service, request);
return response.InTask();
}

Reference:

ServiceStack/ServiceStack/blob/862b74d6bfeacb62706b34e0e8f2ca86c5af4066/src/ServiceStack/Auth/AuthProviderSync.cs#L309


    {
        if (!userName.EqualsIgnoreCase(session.UserAuthName))
            return false;
    }
    return true;
}


public Task<object> LogoutAsync(IServiceBase service, Authenticate request, CancellationToken token = default)
{
    Logout(service, request);
    return TypeConstants.EmptyTask;
}


public Task<object> AuthenticateAsync(IServiceBase authService, IAuthSession session, Authenticate request, CancellationToken token = default)
{
    var response = Authenticate(authService, session, request);
    return response.InTask();
}


public abstract bool IsAuthorized(IAuthSession session, IAuthTokens tokens, Authenticate request = null);

mythz · December 18, 2020, 7:34am

Yeah it should’ve been, fixed in this commit, this change is available from the latest v5.10.3 that’s now on MyGet.

AuthProviderSync LogoutAsync should return response from Logout

I think AuthProviderSync implemantation of LogoutAsync should return response from Logout, that could be for example redirect.

public Task LogoutAsync(IServiceBase service, Authenticate request, CancellationToken token = default) { // Logout(service, request); // return TypeConstants.EmptyTask; // Should return response from Logout() var response = Logout(service, request); return response.InTask(); }

public Task LogoutAsync(IServiceBase service, Authenticate request, CancellationToken token = default)
{
// Logout(service, request);
// return TypeConstants.EmptyTask;
// Should return response from Logout()
var response = Logout(service, request);
return response.InTask();
}