Bug in CsvRequestLogger

grexican · August 17, 2018, 8:12pm

ServiceStack/ServiceStack/blob/master/src/ServiceStack/CsvRequestLogger.cs#L33


private readonly string requestLogsPattern;
private readonly string errorLogsPattern;
private readonly TimeSpan appendEverySecs;
private readonly Timer timer;


public CsvRequestLogger(IVirtualFiles files = null, string requestLogsPattern = null, string errorLogsPattern = null, TimeSpan? appendEvery = null)
{
    this.files = files ?? new FileSystemVirtualFiles(HostContext.Config.WebHostPhysicalPath);
    this.requestLogsPattern = requestLogsPattern ?? "requestlogs/{year}-{month}/{year}-{month}-{day}.csv";
    this.errorLogsPattern = errorLogsPattern ?? "requestlogs/{year}-{month}/{year}-{month}-{day}-errors.csv";
    this.appendEverySecs = appendEvery ?? TimeSpan.FromSeconds(1);


    var lastEntry = ReadLastEntry(GetLogFilePath(this.requestLogsPattern, CurrentDateFn()));
    if (lastEntry != null)
        requestId = lastEntry.Id;


    timer = new Timer(OnFlush, null, this.appendEverySecs, Timeout.InfiniteTimeSpan);
}


private RequestLogEntry ReadLastEntry(string logFile)
{

Shouldn’t that line be TotalMilliseconds not TotalSeconds?

The amount of time to delay before is invoked, in milliseconds.

mythz · August 17, 2018, 8:40pm

Yeah, I’ve changed it to use TimeSpan to remove any ambiguity on what the Timer accepts in this commit.

This change is available from v5.1.1 that’s now available on MyGet.