Exception calling UpdateNonDefaults

mauve · November 16, 2022, 6:59am

Hi,

when I call this.Db.UpdateNonDefaults I get an argument exception “No non-null or non-default values were provided for type: …”.

Is there an elegant way to check whether the object that should be saved has any non-null values?

Greetings
Andre

mythz · November 16, 2022, 10:07am

There’s no proper elegant way as it needs to look at OrmLite metadata field definitions to only look at updatable values which it does in:

github.com

ServiceStack/ServiceStack/blob/f732b949d2d6d4609cded11b155ab4c88e4751f3/ServiceStack.OrmLite/src/ServiceStack.OrmLite/Expressions/SqlExpression.cs#L1403-L1424


foreach (var fieldDef in modelDef.FieldDefinitions)
{
    if (fieldDef.ShouldSkipUpdate()) 
        continue;
    if (fieldDef.IsRowVersion) 
        continue;
    if (UpdateFields.Count > 0
        && !UpdateFields.Contains(fieldDef.Name)) continue; // added


    var value = fieldDef.GetValue(item);
    if (excludeDefaults
        && (value == null || (!fieldDef.IsNullable && value.Equals(value.GetType().GetDefaultValue()))))
        continue;


    if (setFields.Length > 0)
        setFields.Append(", ");


    setFields
        .Append(DialectProvider.GetQuotedColumnName(fieldDef.FieldName))
        .Append("=")

This file has been truncated. show original

A decent approach would be to use ToObjectDictionary extension to convert the instance into a Dictionary<string,object> and check if it has any values which aren’t null or !Equals(value, type.GetDefaultValue()) or the PrimaryKey.