HttpUtils.PostStreamToUrl typo in Stream CopyTo()?

nntdev · August 7, 2019, 3:14pm

Hi

I’m trying to use PostStreamToUrl in ServiceStack 5.5.0 under .Net 472, at runtime this method throws a System.NotSupportedException: ‘Stream does not support reading.’

Looking at the code it looks like the stream CopyTo() is back to front.

github.com

ServiceStack/ServiceStack.Text/blob/e91e67899e084b3363094b99d87effbd6aeb2404/src/ServiceStack.Text/HttpUtils.cs#L804




    if (ResultsFilter != null)
    {
        return new MemoryStream(ResultsFilter.GetBytes(webReq, requestBody.ReadFully()));
    }


    if (requestBody != null)
    {
        using (var req = PclExport.Instance.GetRequestStream(webReq))
        {
            req.CopyTo(requestBody);
        }
    }


    var webRes = PclExport.Instance.GetResponse(webReq);
    responseFilter?.Invoke((HttpWebResponse)webRes);


    var stream = webRes.GetResponseStream();
    return stream;
}

Switching line 804 to the following fixes the problem

requestBody.CopyTo(req);

Regards
Mark

mythz · August 7, 2019, 5:23pm

Yeah you’re right, fixed in this commit this change is available from v5.6.1 that’s now available on MyGet.