MultiSettingsWrapper Set - only first?

sirthomas · September 12, 2016, 9:07pm

Noticed that in the MultiSettingsWrapper class, the call to set will only call set on the first item it finds rather than call set on each of the IAppSettings it finds in the enumerable.

My concern is that if I want to store my fallback values in a database, and support local text-file overrides, I cannot use the API to “set” my new default … since the txt file will be first and my db last. What would be the harm of issuing the set call on each appSettings? In that case, those that don’t support write are ok (eg: my local text file overrides) but I can still update the default db settings.

Anyone have thoughts on this?

github.com

ServiceStack/ServiceStack/blob/7a4fa31b1e974b6a930e278117477396da5994e2/src/ServiceStack/Configuration/MultiAppSettings.cs#L43


                    .FirstOrDefault(value => value != null);
            }


            public List<string> GetAllKeys()
            {
                var allKeys = new HashSet<string>();
                appSettings.Each(s => s.GetAllKeys().Each(x => allKeys.Add(x)));
                return allKeys.ToList();
            }


            public void Set<T>(string key, T value)
            {
                var appSetting = appSettings.First();
                appSetting.Set(key, value);
            }
        }
    }
}

mythz · September 13, 2016, 12:07am

Yeah it should be written to all appSettings giving it the same behavior as a write-thru cache which I’ve changed in this commit.

This change is now available from v4.5.1 that’s not available on MyGet.