RequestLogsFeature local time

Eaton · October 7, 2018, 6:53pm

Is it possible to change the DateTime used in the RequestLogsFeature to local instead of UTC?
This means that DateTime fields in the log entries will be displayed as local date strings, and the logging will start fresh at midnight local time instead of UTC time.

This would help with readability when glancing at raw logs exposed via the AtRestPath endpoint. The UTC dates make it a little annoying to interpret at a glance.

mythz · October 7, 2018, 11:59pm

We specifically use UTC for most Dates in order to generate predictable consistent dates across different servers in multiple time zones. I’ve added a filter you can use to customize the RequestLogEntry in this commit so you can customize the LogEntry with:

Plugins.Add(new RequestLogsFeature { 
    RequestLogFilter = (req,entry) => entry.DateTime = DateTime.Now
});

This change is available from v5.4.1 that’s now available on MyGet.

Eaton · October 8, 2018, 3:30am

That’s understandable, thank you for adding the filter though.
Will this move new log creation to midnight of the specified date too, or is that something else?

mythz · October 8, 2018, 11:03am

Are you talking about CSV Request Logger? As that uses something else in:

github.com

ServiceStack/ServiceStack/blob/90e444a7bf26c498179d0d05341f41000b27efb1/src/ServiceStack/CsvRequestLogger.cs#L96


        logsSnapshot = this.logs;
        this.logs = new List<RequestLogEntry>();
    }
    if (errorLogs.Count > 0)
    {
        errorLogsSnapshot = this.errorLogs;
        this.errorLogs = new List<RequestLogEntry>();
    }
}


var now = DateTime.UtcNow;
if (logsSnapshot != null)
{
    var logFile = GetLogFilePath(requestLogsPattern, now);
    WriteLogs(logsSnapshot, logFile);
}
if (errorLogsSnapshot != null)
{
    var logFile = GetLogFilePath(errorLogsPattern, now);
    WriteLogs(errorLogsSnapshot, logFile);
}

You’d need a custom CsvRequestLogger that overrides OnFlush() with your own custom impl.

mythz · October 9, 2018, 1:53am

Decided to add a specific CurrentDateFn option to change what to use for the Current Date in all Request Logger providers, so now you can change to use Local Time with:

Plugins.Add(new RequestLogsFeature { 
    CurrentDateFn = () => DateTime.Now
});

This change is now available on MyGet, if you had v5.4.1 installed you’ll need to clear your NuGet cache.

Eaton · October 10, 2018, 1:16am

That’s great, thank you.
I’ll give it a try soon…

Eaton · October 10, 2018, 10:55pm

Hm, I’m getting a startup crash. I don’t even set CurrentDateFn and it happens. Does it work on your end?

mythz · October 11, 2018, 12:44am

This suggests you have dirty .dll’s where you still have an old ServiceStack.dll. Make sure you clear your NuGet packages cache so you’re using the latest version, e.g:

$ nuget locals all -clear

Eaton · October 11, 2018, 1:13am

That doesn’t appear to be the issue. I’ve verified the deployed dlls on the server are v5.4.1 from 2 days ago.
Just in case, I deleted the whole packages folder from my project, restored, and get the same dlls.

mythz · October 11, 2018, 1:51am

The pre-release packages have the same version number so you could have an old v5.4.1 .dll’s mixed with the newer version that has the CurrentDateFn which is the only way you can get this error since the .dll that has this feature has this method.

Make sure you’re running this on the command line with a recent NuGet.exe to clear your local NuGet packages cache

$ nuget locals all -clear

Eaton · October 11, 2018, 3:11am

I ran that command, caches cleared successfully, still getting the crash.
I created a new project that reproduces the crash. Run it with the latest MyGet packages restored and you should see this:

mythz · October 11, 2018, 7:31am

ok I’ve re-run all CI projects and published to MyGet again. Your project runs without issue so if you clear your NuGet cache again, you should no longer have this issue.

Eaton · October 11, 2018, 5:48pm

Yup, now it works.