Should JsonHttpClient be dependent on ServiceStack.Client?

ristaloff · February 11, 2016, 10:45am

I created a new project and added the JsonHttpClient nuget package.
I create a client like this:
IServiceClient client = new JsonHttpClient(“http://techstacks.io”);
I then get the following error:
"The type ‘IHasCookieContainer’ is defined in an assembly that is not referenced. You must add a reference to assembly ‘ServiceStack.Client, Version=4.0.52.0, Culture=neutral, PublicKeyToken=null’.

If JsonHttpClient is dependent on servicestack.client shouldn’t that be included as a dependency in the nuget package?

mythz · February 11, 2016, 2:03pm

Sounds like you have dirty dlls, I’d check the version of all your ServiceStack.Client NuGet packages to make sure you’re referencing the same v4.0.52.

Deleting your NuGet /packages folder, restarting VS + rebuilding the project will bring just the packages that are referenced and will be able to show which packages that are being referenced are not v4.0.52.

ristaloff · February 11, 2016, 8:44pm

JsonHttpClients implements 3 interfaces. IServiceClient and IJsonServiceClient which are in ServiceStack.Interfaces.
And IHasCookieContainer which is in ServiceStack.Client. As far as I can see.

I found the IHasCookieContainer interface here:

github.com

ServiceStack/ServiceStack/blob/master/src/ServiceStack.Client/ServiceClientBase.cs#L1686


                }
            }


            outputStream.Write(newLine);
            if (fileCount == files.Length - 1) outputStream.Write(boundary + "--");
        }
    }


    return webRequest;
}


try
{
    var webRequest = createWebRequest();
    var webResponse = webRequest.GetResponse();
    return HandleResponse<TResponse>(webResponse);
}
catch (Exception ex)
{
    // restore original position before retry
    files[fileCount - 1].Stream.Seek(currentStreamPosition, SeekOrigin.Begin);

mythz · February 11, 2016, 8:47pm

Right, it’s in the ServiceStack.Client.dll which ServiceStack.HttpClient has a dependency on. Are you referencing v4.0.52 package for HttpClient?

ristaloff · February 11, 2016, 8:48pm

Yes. When I get the ServiceStack.HttpClient from nuget ServiceStack.Client is not listed as a dependency and it is not downloaded.

ristaloff · February 11, 2016, 8:50pm

The dependency is not listed here:
https://github.com/ServiceStack/ServiceStack/blob/master/NuGet/ServiceStack.HttpClient/servicestack.httpclient.nuspec

mythz · February 11, 2016, 8:51pm

Yep thanks, I’ve just added it in this commit. You’ll need to manually reference ServiceStack.Client for v4.0.52.

ristaloff · February 11, 2016, 8:52pm

Ok good, just wanted to make sure I was thinking correctly Thanks for swift reply as always!