Why do the DeleteAll() and DeleteAllAsync() method behave differently?

Drammy · May 2, 2025, 12:54pm

The method names suggest they should perform the same function; just one is async and the other not.

However, if I understand it correctly…

DeleteAll() takes a list of record pocos to delete from a table, and
DeleteAllAsync() deletes all records from a given table by type.

mythz · May 2, 2025, 1:08pm

These 2 are methods are equivalent:

github.com

ServiceStack/ServiceStack/blob/a4df3aaa6b33fafb153359118b6fcec60a7138b3/ServiceStack.OrmLite/src/ServiceStack.OrmLite/OrmLiteWriteApi.cs#L395-L398


      
          public static int DeleteAll<T>(this IDbConnection dbConn)
          {
              return dbConn.Exec(dbCmd => dbCmd.DeleteAll<T>());
          }

Async:

github.com

ServiceStack/ServiceStack/blob/a4df3aaa6b33fafb153359118b6fcec60a7138b3/ServiceStack.OrmLite/src/ServiceStack.OrmLite/OrmLiteWriteApiAsync.cs#L308-L311


      
          public static Task<int> DeleteAllAsync<T>(this IDbConnection dbConn, CancellationToken token = default)
          {
              return dbConn.Exec(dbCmd => dbCmd.DeleteAllAsync<T>(token));
          }

It was missing an equivalent DeleteAllAsync(rows) API which has been added in this commit.